Skip to content

Conversation

joecummings
Copy link
Member

Context

These were kept around while testing the vLLM load_weights function, but it appears to work and this just clutters up the code.

Changes

  • Removed all methods marked _DEPRECATED
  • Removed use_vllm_builtin b/c it's just always true
  • Modified all callsites and updates imports

Testing

  • sed for DEPRECATED and use_vllm_builtin returns nothing
  • grpo.main still runs

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 10, 2025
@joecummings joecummings merged commit 41215d3 into meta-pytorch:main Oct 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants